bootutil: src: image_validate.c: remove mbedtls headers #2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested changes
Aug 20, 2025
boot/bootutil/src/image_validate.c
Outdated
| @@ -5,6 +5,7 @@ | |||
| * Copyright (c) 2016-2019 JUUL Labs | |||
| * Copyright (c) 2019-2024 Arm Limited | |||
| * Copyright (c) 2025 Nordic Semiconductor ASA | |||
| * Copyright (c) 2025 Analog Devices, Inc. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2025 Analog Devices, Inc. |
boot/bootutil/src/image_validate.c
Outdated
Comment on lines
35
to
36
|
|
||
| //to make INT_MAX available |
There was a problem hiding this comment.
Suggested change
| //to make INT_MAX available |
There was a problem hiding this comment.
Addressed all reviews.
Can we propose "Portions Copyright (c) 2025 Analog Devices, Inc" instead?
There was a problem hiding this comment.
You've changed some includes, I'm not being funny but that is not a contribution that warrants a copyright added to a file, that's not code, that's not even copyrightable
gramshan
force-pushed
the
remove-mbed-headers
branch
from
71a4e25 to
bfaa0fa
Compare
nordicjm
requested changes
Aug 27, 2025
boot/bootutil/src/image_validate.c
Outdated
| @@ -5,6 +5,7 @@ | |||
| * Copyright (c) 2016-2019 JUUL Labs | |||
| * Copyright (c) 2019-2024 Arm Limited | |||
| * Copyright (c) 2025 Nordic Semiconductor ASA | |||
| * Portions Copyright (c) 2025 Analog Devices, Inc | |||
There was a problem hiding this comment.
Suggested change
| * Portions Copyright (c) 2025 Analog Devices, Inc |
removing direct inclusion of mbedtls headers. bootutil has already abstracted away mbedtls apis. Signed-off-by: Gowri Ramshankar <[email protected]>
gramshan
force-pushed
the
remove-mbed-headers
branch
from
bfaa0fa to
59402e3
Compare
nordicjm
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing direct inclusion of mbedtls headers.
bootutil has already abstracted away mbedtls apis.